Feature/pnc related #44
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- variant for `authorization_mode` in `AuthorizationReq` has been introduced - sdp packet buffer size has been increased to 4k, in order to be large enough to contain sample data from josev - crucial bug has been fixed in `ServiceDetail` serialization, where the `ParameterSet` has not been initialized/zero-initialized properly -- this will need some follow up discussion - some PnC related message and state handling has been added/refactored - minor refactorings on conversion functions Signed-off-by: aw <[email protected]>
- some comments have been added, which should be handled in near future Signed-off-by: aw <[email protected]>
Signed-off-by: aw <[email protected]>
SebaLukas
reviewed
Nov 14, 2024
| uint8_t buffer[2048]; | ||
| // FIXME (aw): what buffer size to allow here? Could also be made | ||
| // dynamic | ||
| uint8_t buffer[4096]; |
There was a problem hiding this comment.
Maybe we should start to use std::array instead of a c buffer.
I am fine with increasing the buffer size to 4096. I think that's more of an experience value. 4096 should be enough for now.
|
|
||
| enum class Signal { | ||
| REQUIRE_AUTH_EIM, | ||
| REQUIRE_AUTH_PNC, |
There was a problem hiding this comment.
Here we should send also the contract cert chain from the AuthorizationReq message as well. But only once.
There was a problem hiding this comment.
This does not have to be part of this PR, but will be added when PnC is fully implemented.
| if (not in.discharge_limits) { | ||
| return; | ||
| } | ||
| auto& discharge_limits = in.discharge_limits.value(); |
|
|
||
| // Todo(sl): PnC is currently not supported | ||
| ctx.feedback.signal(session::feedback::Signal::REQUIRE_AUTH_EIM); | ||
| ctx.feedback.signal(required_auth_signal(res)); |
There was a problem hiding this comment.
We should move this feedback.signal call to the authorization state. Only in the authorization state is it clear whether the car is requesting PnC or EIM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
See commit messages
Issue ticket number and link
Checklist before requesting a review